singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [singa] chrishkchris edited a comment on pull request #790: Remove Travis CI
Date Thu, 10 Sep 2020 03:50:52 GMT

chrishkchris edited a comment on pull request #790:

   I think I got the difference between "push" and "pull_request" clearer now:
   From this webpage:
   This page says that:
   "This difference means that a pull_request workflow ref would look like refs/remotes/pull/##/merge
whereas a push workflow would be refs/heads/branch_name. This explains why the SHA of a push
workflow matches the commit that triggered the workflow, whereas the SHA of a pull_request
workflow does not; instead **the SHA of the pull_request is the resulting commit that was
created from merging the base to the head**."
   So the trigger of `pull_request` is very useful because it seems to use the merged code
(from base to head) for test, which accounts for the compatibility to the base branch.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message