singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] chrishkchris edited a comment on pull request #790: Remove Travis CI
Date Mon, 07 Sep 2020 06:31:55 GMT

chrishkchris edited a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-688065275


   I have a question: the current CI use the current PR branch for CI test. 
   
   In this case, if one PR fixes a bug that cause a failed CI test, some other PR still cannot
pass the test unless rebased to dev branch
   Also another problem is that if team members A and B working on the same branch, their
code can pass the CI test separately, but may not be compatible to each other (e.g. due to
API change)
   
   
   Would it be a better practice if we use the merged code instead of the PR branch for CI
test?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message