singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] dcslin commented on pull request #789: fixed imdb train script args
Date Mon, 07 Sep 2020 03:20:51 GMT

dcslin commented on pull request #789:
URL: https://github.com/apache/singa/pull/789#issuecomment-688003289


   > I remembered last time is this problem?
   > 
   > ![577d5bfda72d47956db1b3439705862](https://user-images.githubusercontent.com/38325429/92297015-4e28ec80-ef6d-11ea-996e-63aba1d10490.png)
   > ![d32bb0f4bdef62a3f989e53e8b4c15d](https://user-images.githubusercontent.com/38325429/92297017-4f5a1980-ef6d-11ea-9c89-41883e76cdc8.png)
   
   Hi Chirs, I think the bug was because the `argpaser` configuration was wrong. And the `args.return_sequences`
has string value of `"False"` which is evaluated to `True`(not `None`) in `if` statement.
So the changes in this PR rectified the `argpaser` to make `args.return_sequences` has boolean
value.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message