From dev-return-6073-archive-asf-public=cust-asf.ponee.io@singa.apache.org Mon Jul 27 02:50:16 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 6BBF318061A for ; Mon, 27 Jul 2020 04:50:16 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 5FE5D1253F5 for ; Mon, 27 Jul 2020 02:50:14 +0000 (UTC) Received: (qmail 21967 invoked by uid 500); 27 Jul 2020 02:50:13 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 21957 invoked by uid 99); 27 Jul 2020 02:50:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jul 2020 02:50:13 +0000 From: =?utf-8?q?GitBox?= To: dev@singa.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bsinga=5D_dcslin_commented_on_pull_request_=23724?= =?utf-8?q?=3A_add_embedding_layer?= Message-ID: <159581821375.29655.3871406101282289308.asfpy@gitbox.apache.org> Date: Mon, 27 Jul 2020 02:50:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: dcslin commented on pull request #724: URL: https://github.com/apache/singa/pull/724#issuecomment-664091056 > > hi @joddiy , i resolve previous issue. could you please help to take a look at this: > > in your test, updating `X = np.random.randint(5, size=(2, 4))` to `X = np.array([[0,1,2,3],[9,8,7,6]])` will give error: > > ``` > > F0726 14:38:29.124913 10729 tensor.cc:1256] Check failed: in.shape(0) >= end (8 vs. 10) Tensor size must >= end > > ``` > > Hi, shicong, it exists a little bug in the backward of embedding, it has been fixed now, please check again. Thank you @joddiy , this is tested and it is ok now from my side. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org