From dev-return-5955-archive-asf-public=cust-asf.ponee.io@singa.apache.org Fri Jul 3 04:39:31 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3FAE818037A for ; Fri, 3 Jul 2020 06:39:31 +0200 (CEST) Received: (qmail 67184 invoked by uid 500); 3 Jul 2020 04:39:30 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 67166 invoked by uid 99); 3 Jul 2020 04:39:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jul 2020 04:39:30 +0000 From: =?utf-8?q?GitBox?= To: dev@singa.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bsinga=5D_chrishkchris_commented_on_pull_request_?= =?utf-8?q?=23758=3A_update_roundeven_backend_algorithm?= Message-ID: <159375117003.29655.15635011259051053521.asfpy@gitbox.apache.org> Date: Fri, 03 Jul 2020 04:39:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: chrishkchris commented on pull request #758: URL: https://github.com/apache/singa/pull/758#issuecomment-653341627 @dcslin The test case looks good to me https://blogs.sas.com/content/iml/2019/11/11/round-to-even.html As the example given in the link above, `rounde` rounds 0.5 to 0, and 2.5 to 2 The test case passed so it should be correct. ``` root@71ac539cda77:~/dcsysh/singa/test/python# python3 test_api.py ................................. ---------------------------------------------------------------------- Ran 33 tests in 0.758s OK ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org