singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] dcslin commented on pull request #724: add embedding layer
Date Mon, 27 Jul 2020 02:50:13 GMT

dcslin commented on pull request #724:
URL: https://github.com/apache/singa/pull/724#issuecomment-664091056


   > > hi @joddiy , i resolve previous issue. could you please help to take a look at
this:
   > > in your test, updating `X = np.random.randint(5, size=(2, 4))` to `X = np.array([[0,1,2,3],[9,8,7,6]])`
will give error:
   > > ```
   > > F0726 14:38:29.124913 10729 tensor.cc:1256] Check failed: in.shape(0) >= end
(8 vs. 10) Tensor size must >= end
   > > ```
   > 
   > Hi, shicong, it exists a little bug in the backward of embedding, it has been fixed
now, please check again.
   
   Thank you @joddiy , this is tested and it is ok now from my side.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message