singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] moazreyad commented on a change in pull request #761: C++ build with Github Actions
Date Mon, 13 Jul 2020 09:34:54 GMT

moazreyad commented on a change in pull request #761:
URL: https://github.com/apache/singa/pull/761#discussion_r453521161



##########
File path: .github/workflows/cpp.yaml
##########
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# This is a basic workflow to help you get started with Actions
+
+name: C++
+
+# Controls when the action will run. Triggers the workflow on push or pull request
+# events but only for the master branch
+on:
+  push:
+    branches:
+      - master
+      - dev
+  pull_request:
+    branches:
+      - master
+      - dev
+
+# A workflow run is made up of one or more jobs that can run sequentially or in parallel
+jobs:
+  build-ubuntu-cpp:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v1
+      - name: install-build-dependencies
+        run: sudo apt-get install -y libgoogle-glog-dev libprotobuf-dev protobuf-compiler
libncurses-dev libopenblas-dev gfortran libblas-dev liblapack-dev libatlas-base-dev swig libcurl3-dev
cmake dh-autoreconf  
+      - name: configure
+        run: mkdir build && cd build && cmake -DUSE_PYTHON=NO ..

Review comment:
       Thank you for the revision, here are some comments:
   
   1. The MKL-DNN is now called [oneDNN](https://github.com/oneapi-src/oneDNN)
   
   2. If the flag -DUSE_DNNL is always required to pass the C++ tests, then why it is an optional
flag? It should be always ON by default since the system does not work without it. (i.e. the
system does not pass the unit tests without it)
   
   3. If the C++ unit tests can work without the -DUSE_DNNL flag except few unit tests, then
I propose to add "ifdef USE_DNNL" around the unit tests that require DNNL:
   
   ```
   #ifdef USE_DNNL
   
   .. unit test code
   
   #endif
   ```
   
   
   So that these unit tests are not compiled if they don't support the given configuration
to cmake.
   
   What do you think?
   
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message