singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] joddiy edited a comment on pull request #760: Scatter
Date Sun, 12 Jul 2020 21:59:54 GMT

joddiy edited a comment on pull request #760:
URL: https://github.com/apache/singa/pull/760#issuecomment-657281203


   Please check my PR:
   
   https://github.com/Shashankwer/singa/pull/1
   
   For the arguments of forward function, we should only contain the argument which has a
gradient. for example, in this operator, only x have the gradient, so we move other arguments(indices
and updates) to `__init__` function.
   
   By the way, I think the advanced indexing idea is fine, could we implement it without numpy?
since we will move this implement to c++ end later. Any function using the dependency will
be a problem then.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message