singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] joddiy commented on pull request #760: Scatter
Date Sun, 12 Jul 2020 21:56:04 GMT

joddiy commented on pull request #760:
URL: https://github.com/apache/singa/pull/760#issuecomment-657281203


   Please check my PR:
   
   https://github.com/Shashankwer/singa/pull/1
   
   There are two points you should pay attention:
   1. the implement should be as clear as possible.
   2. for the arguments of forward function, we should only contain the argument which has
a gradient. for example, in this operator, only x have the gradient, so we move other arguments(indices
and updates) to `__init__` function.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message