singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] chrishkchris commented on pull request #748: add exp && round && rounde operators
Date Fri, 03 Jul 2020 13:01:39 GMT

chrishkchris commented on pull request #748:
URL: https://github.com/apache/singa/pull/748#issuecomment-653537520


   I tested your code with your test case. 
   
   ```
   root@71ac539cda77:~/dcsysh/singa/test/python# python3 test_operation.py TestPythonOperation.test_round_cpu
   .
   ----------------------------------------------------------------------
   Ran 1 test in 0.001s
   
   OK
   root@71ac539cda77:~/dcsysh/singa/test/python# python3 test_operation.py TestPythonOperation.test_round_gpu
   .
   ----------------------------------------------------------------------
   Ran 1 test in 0.001s
   
   OK
   root@71ac539cda77:~/dcsysh/singa/test/python# python3 test_operation.py TestPythonOperation.test_rounde_cpu
   .
   ----------------------------------------------------------------------
   Ran 1 test in 0.001s
   
   OK
   root@71ac539cda77:~/dcsysh/singa/test/python# python3 test_operation.py TestPythonOperation.test_rounde_gpu
   .
   ----------------------------------------------------------------------
   Ran 1 test in 0.002s
   
   OK
   ```
   
   The code looks good to me. So I merged the code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message