singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] chrishkchris commented on a change in pull request #758: update roundeven backend algorithm
Date Thu, 02 Jul 2020 16:53:40 GMT

chrishkchris commented on a change in pull request #758:
URL: https://github.com/apache/singa/pull/758#discussion_r449146902



##########
File path: src/core/tensor/math_kernel.cu
##########
@@ -140,7 +140,12 @@ __global__ void KernelRound(const size_t n, const float *in, float *out)
{
 __global__ void KernelRoundE(const size_t n, const float *in, float *out) {
   for (int i = blockIdx.x * blockDim.x + threadIdx.x; i < n;
        i += blockDim.x * gridDim.x) {
-    out[i] = roundf(in[i]/2)*2;
+    auto doub = in[i]*2;

Review comment:
       This auto causes problem in CXX complier version 5.4, upgraded to 7.5.0 will then be
okay. Resolved in #759




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message