singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] nudles commented on a change in pull request #753: fix test operation Tensor class non hashable erorr
Date Wed, 01 Jul 2020 01:33:12 GMT

nudles commented on a change in pull request #753:
URL: https://github.com/apache/singa/pull/753#discussion_r448067222



##########
File path: python/singa/autograd.py
##########
@@ -117,7 +117,11 @@ def gradients(y, dy=None):
     """
     grads = {}  # mapping: x->dx if x.stores_grad
     for p, dp in backward(y, dy):
-        grads[p] = dp
+        # TODO: this fn is only helper for test case for now.
+        #   1. could implement __hash__ or

Review comment:
       ok. then pls update the docstring for the returned data.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message