From dev-return-5798-archive-asf-public=cust-asf.ponee.io@singa.apache.org Tue Jun 16 09:42:09 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3B48E180621 for ; Tue, 16 Jun 2020 11:42:09 +0200 (CEST) Received: (qmail 46984 invoked by uid 500); 16 Jun 2020 09:42:07 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 46927 invoked by uid 99); 16 Jun 2020 09:42:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jun 2020 09:42:07 +0000 From: =?utf-8?q?GitBox?= To: dev@singa.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bsinga=5D_nudles_commented_on_a_change_in_pull_requ?= =?utf-8?q?est_=23731=3A_fix_the_bug_of_param_name?= Message-ID: <159230052730.8807.14018894933931077878.asfpy@gitbox.apache.org> Date: Tue, 16 Jun 2020 09:42:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: nudles commented on a change in pull request #731: URL: https://github.com/apache/singa/pull/731#discussion_r440722489 ########## File path: python/singa/layer.py ########## @@ -499,7 +581,7 @@ def initialize(self, x): self.kernel_size[0], self.kernel_size[1], ) - w_name = self.name + Layer.sep + 'W' + w_name = self.get_param_name('W') Review comment: if a user set the name of a param explicitly, then we should not change it implicitly by prepending a prefix to it. e.g., if a user call `W.name = "Weight"`, then we should not change it to "layer1.conv1.Weight" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org