From dev-return-5790-archive-asf-public=cust-asf.ponee.io@singa.apache.org Tue Jun 16 07:27:44 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A9CCA180621 for ; Tue, 16 Jun 2020 09:27:43 +0200 (CEST) Received: (qmail 83007 invoked by uid 500); 16 Jun 2020 07:27:43 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 82997 invoked by uid 99); 16 Jun 2020 07:27:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jun 2020 07:27:43 +0000 From: =?utf-8?q?GitBox?= To: dev@singa.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bsinga=5D_XJDKC_commented_on_a_change_in_pull_reque?= =?utf-8?q?st_=23731=3A_fix_the_bug_of_param_name?= Message-ID: <159229246294.8807.3270322286822646294.asfpy@gitbox.apache.org> Date: Tue, 16 Jun 2020 07:27:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: XJDKC commented on a change in pull request #731: URL: https://github.com/apache/singa/pull/731#discussion_r440640754 ########## File path: python/singa/layer.py ########## @@ -499,7 +581,7 @@ def initialize(self, x): self.kernel_size[0], self.kernel_size[1], ) - w_name = self.name + Layer.sep + 'W' + w_name = self.get_param_name('W') Review comment: Has addressed the problems mentioned above. Ready to merge. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org