From dev-return-5692-archive-asf-public=cust-asf.ponee.io@singa.apache.org Sat Jun 6 15:40:03 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 232EF180608 for ; Sat, 6 Jun 2020 17:40:03 +0200 (CEST) Received: (qmail 50004 invoked by uid 500); 6 Jun 2020 15:40:02 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 49994 invoked by uid 99); 6 Jun 2020 15:40:02 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Jun 2020 15:40:02 +0000 From: =?utf-8?q?GitBox?= To: dev@singa.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bsinga=5D_chrishkchris_commented_on_a_change_in_pul?= =?utf-8?q?l_request_=23716=3A_SINGA-510_Distributed_Training_Time_Profiling?= Message-ID: <159145800236.17834.6468575023988922683.asfpy@gitbox.apache.org> Date: Sat, 06 Jun 2020 15:40:02 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: chrishkchris commented on a change in pull request #716: URL: https://github.com/apache/singa/pull/716#discussion_r436278084 ########## File path: src/core/device/cuda_gpu.cc ########## @@ -120,9 +132,41 @@ void CudaGPU::TimeProfilingDoExec(function&& fn, int executor, cudaEventCreate(&(node->start_)); cudaEventCreate(&(node->end_)); +#ifdef USE_DIST Review comment: which one do you prefer? I can use USE_CUDA in common.h instead ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org