From dev-return-5675-archive-asf-public=cust-asf.ponee.io@singa.apache.org Sat Jun 6 14:40:51 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 76C6C180608 for ; Sat, 6 Jun 2020 16:40:51 +0200 (CEST) Received: (qmail 21250 invoked by uid 500); 6 Jun 2020 14:40:50 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 21240 invoked by uid 99); 6 Jun 2020 14:40:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Jun 2020 14:40:50 +0000 From: =?utf-8?q?GitBox?= To: dev@singa.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bsinga=5D_XJDKC_commented_on_a_change_in_pull_reque?= =?utf-8?q?st_=23716=3A_SINGA-510_Distributed_Training_Time_Profiling?= Message-ID: <159145445062.17834.12596904224054734857.asfpy@gitbox.apache.org> Date: Sat, 06 Jun 2020 14:40:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: XJDKC commented on a change in pull request #716: URL: https://github.com/apache/singa/pull/716#discussion_r436273939 ########## File path: src/io/communicator.cc ########## @@ -179,14 +175,14 @@ void Communicator::wait() { device_->Exec( [this](Context *ctx) mutable { // synchronizing on all the CUDA streams used by communicator - CUDA_CHECK(cudaEventRecord(event, s)); - CUDA_CHECK(cudaStreamWaitEvent(NULL, event, 0)); - CUDA_CHECK(cudaEventRecord(event, c1)); - CUDA_CHECK(cudaStreamWaitEvent(NULL, event, 0)); - CUDA_CHECK(cudaEventRecord(event, c2)); - CUDA_CHECK(cudaStreamWaitEvent(NULL, event, 0)); + CUDA_CHECK(cudaEventRecord(event, ctx->s)); + CUDA_CHECK(cudaStreamWaitEvent(ctx->stream, event, 0)); + CUDA_CHECK(cudaEventRecord(event, ctx->c1)); + CUDA_CHECK(cudaStreamWaitEvent(ctx->stream, event, 0)); + CUDA_CHECK(cudaEventRecord(event, ctx->c2)); + CUDA_CHECK(cudaStreamWaitEvent(ctx->stream, event, 0)); }, - blocks_, blocks_, "wait"); + blocks_, blocks_, "Sync"); Review comment: Got it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org