singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] nudles commented on a change in pull request #731: fix the bug of param name
Date Tue, 16 Jun 2020 09:42:07 GMT

nudles commented on a change in pull request #731:
URL: https://github.com/apache/singa/pull/731#discussion_r440722489



##########
File path: python/singa/layer.py
##########
@@ -499,7 +581,7 @@ def initialize(self, x):
             self.kernel_size[0],
             self.kernel_size[1],
         )
-        w_name = self.name + Layer.sep + 'W'
+        w_name = self.get_param_name('W')

Review comment:
       if a user set the name of a param explicitly, then we should not change it implicitly
by prepending a prefix to it.
   e.g., if a user call `W.name = "Weight"`, then we should not change it to "layer1.conv1.Weight"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message