singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] XJDKC commented on a change in pull request #731: fix the bug of param name
Date Tue, 16 Jun 2020 04:42:06 GMT

XJDKC commented on a change in pull request #731:
URL: https://github.com/apache/singa/pull/731#discussion_r440582387



##########
File path: python/singa/layer.py
##########
@@ -158,6 +217,21 @@ def _get_unique_name(self):
             self.name = ''
         return self.name

Review comment:
       2. This scheme will reset the layer name many times. 
   ```python
   1. model.\_\_init\_\_
   2. layer1.\_\_init\_\_
   3. layer2.\_\_init\_\_
   4. layer3.\_\_init\_\_
   5. layer2.\_\_setattr\_\_: reset the name of layer3
   6. layer1.\_\_setattr\_\_: reset the names of layer2 and layer3
   7. model.\_\_setattr\_\_: reset the names of laye1, layer2 and layer3
   ```
   3. the tensor has a default name if user doesn't set the name.https://github.com/apache/singa/blob/master/python/singa/tensor.py#L116
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message