singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] nudles commented on a change in pull request #728: Fix create_cuda_gpu
Date Wed, 10 Jun 2020 13:59:27 GMT

nudles commented on a change in pull request #728:
URL: https://github.com/apache/singa/pull/728#discussion_r438144122



##########
File path: python/singa/device.py
##########
@@ -106,17 +106,21 @@ def create_cuda_gpus(num):
     return singa.Platform.CreateCudaGPUs(num)
 
 
-def create_cuda_gpu(set_default=False):
+Device.default_gpu_device = None

Review comment:
       in fact, I think we are not using the Device class?
   shall we just remove it and make default_gpu_device an attribute of the device module?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message