singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] chrishkchris commented on a change in pull request #716: SINGA-510 Distributed Training Time Profiling
Date Sat, 06 Jun 2020 16:00:22 GMT

chrishkchris commented on a change in pull request #716:
URL: https://github.com/apache/singa/pull/716#discussion_r436279603



##########
File path: src/core/device/cuda_gpu.cc
##########
@@ -120,9 +132,41 @@ void CudaGPU::TimeProfilingDoExec(function<void(Context*)>&&
fn, int executor,
   cudaEventCreate(&(node->start_));
   cudaEventCreate(&(node->end_));
 
+#ifdef USE_DIST

Review comment:
       > Yeah, we need big changes to solve this problem(e.g. passing a struct named OpDescriptor
to the device). I think we just keep it like this for now.
   
   Yes, I guess OpDescriptor would be useful to record many context regarding the operator.
I think it is good to include it in the future




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message