singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] chrishkchris commented on a change in pull request #716: SINGA-510 Distributed Training Time Profiling
Date Sat, 06 Jun 2020 14:55:53 GMT

chrishkchris commented on a change in pull request #716:
URL: https://github.com/apache/singa/pull/716#discussion_r436275077



##########
File path: include/singa/io/communicator.h
##########
@@ -98,16 +98,16 @@ class Communicator {
   void generateBlocks(Tensor &t);
   void generateBlocks(std::vector<Tensor> &t);
   void allReduce(int size, void *sendbuff, void *recvbuff,
-                 ncclDataType_t ncclType);
+                 ncclDataType_t ncclType, Context *ctx);

Review comment:
       oh I will go to delete the three lines in the communicator.h header:
     cudaStream_t s;
     cudaStream_t c1;
     cudaStream_t c2;




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message