singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] joddiy commented on issue #700: Expand the model zoo (example model set)
Date Wed, 03 Jun 2020 15:24:51 GMT

joddiy commented on issue #700:
URL: https://github.com/apache/singa/issues/700#issuecomment-638269854


   > Hi @joddiy,
   > 
   > For Shufflenetv2 the model conversion is failing due to use of ceil_mode. Although
the value is set to false in onnx model (0) its still failing at a condition.
   > 
   > I have opened a new issue for the same. If we can split the condition checking
   > 
   > ```
   > if "count_include_pad" in onnx_node.attrs or "ceil_mode" in onnx_node.attrs
   > ```
   > 
   > to
   > 
   > ```
   > if "ceil_mode" in onnx_node.attrs and onnx_node.attrs["ceil_mode"]:
   >   RaiseError
   > if "count_include_pad" in onnx_node.attrs:
   >   RaiseError
   > ```
   > 
   > Shufflenetv2 can be successfully converted to singa.
   
   Thanks, @Shashankwer , you can open a PR update like this:
   ```
   ceil_mode = onnx_node.getattr("ceil_mode", 0)
   count_include_pad = onnx_node.getattr("count_include_pad", 0)
   if ceil_mode != 0 or count_include_pad != 0:
   ...
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message