From dev-return-5434-archive-asf-public=cust-asf.ponee.io@singa.apache.org Sat May 23 04:02:18 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 957DD18057A for ; Sat, 23 May 2020 06:02:18 +0200 (CEST) Received: (qmail 86446 invoked by uid 500); 23 May 2020 04:02:17 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 86436 invoked by uid 99); 23 May 2020 04:02:17 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 May 2020 04:02:17 +0000 From: =?utf-8?q?GitBox?= To: dev@singa.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bsinga=5D_XJDKC_commented_on_a_change_in_pull_reque?= =?utf-8?q?st_=23708=3A_SINGA-510_Improvement_of_Time_Profiling_Function?= Message-ID: <159020653748.19379.12989783556158373782.asfpy@gitbox.apache.org> Date: Sat, 23 May 2020 04:02:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: XJDKC commented on a change in pull request #708: URL: https://github.com/apache/singa/pull/708#discussion_r429511478 ########## File path: src/core/scheduler/scheduler.cc ########## @@ -325,9 +337,10 @@ void Graph::RunGraph() { } } + EvaluateTimeElapsed(); Review comment: I think we should call the step function before EvaluateTimeElapsed. Otherwise, it may have problems when dividing the time if the skip_iteration is zero. ########## File path: src/core/scheduler/scheduler.cc ########## @@ -325,9 +337,10 @@ void Graph::RunGraph() { } } + EvaluateTimeElapsed(); + // increment iteration counter step(); Review comment: Remember to clear the elapsed time and the iteration when resetting the graph. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org