From dev-return-5400-archive-asf-public=cust-asf.ponee.io@singa.apache.org Wed May 20 09:18:31 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3F2DF180637 for ; Wed, 20 May 2020 11:18:31 +0200 (CEST) Received: (qmail 74286 invoked by uid 500); 20 May 2020 09:18:30 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 74276 invoked by uid 99); 20 May 2020 09:18:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 May 2020 09:18:30 +0000 From: =?utf-8?q?GitBox?= To: dev@singa.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bsinga=5D_chrishkchris_commented_on_a_change_in_pul?= =?utf-8?q?l_request_=23694=3A_SINGA-510_Add_Time_Profiling_for_Single_GPU?= Message-ID: <158996631048.19379.2116729101775125222.asfpy@gitbox.apache.org> Date: Wed, 20 May 2020 09:18:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: chrishkchris commented on a change in pull request #694: URL: https://github.com/apache/singa/pull/694#discussion_r427863586 ########## File path: include/singa/core/device.h ########## @@ -51,6 +51,17 @@ using std::vector; namespace singa { +/// Method used by time profiling +/// ProfilingMode == 0 (default) -> Chrono +/// ProfilingMode == 1 -> Event (e.g. cudaEvent) +enum ProfilingMode { useChrono, useEvent }; Review comment: yes, cpu can use chrono only, gpu can use either 1. chrono or 2. cudaevent Time Profiling methods in NVIDIA documentation: 1. Chrono: https://docs.nvidia.com/deeplearning/sdk/tensorrt-best-practices/index.html#cpu-timing 2. CudaEvent: https://docs.nvidia.com/deeplearning/sdk/tensorrt-best-practices/index.html#cuda-events I have implemented both for GPU ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org