From dev-return-5391-archive-asf-public=cust-asf.ponee.io@singa.apache.org Wed May 20 06:06:46 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 13A0A180637 for ; Wed, 20 May 2020 08:06:45 +0200 (CEST) Received: (qmail 99027 invoked by uid 500); 20 May 2020 06:06:45 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 98927 invoked by uid 99); 20 May 2020 06:06:44 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 May 2020 06:06:44 +0000 From: =?utf-8?q?GitBox?= To: dev@singa.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bsinga=5D_joddiy_commented_on_issue_=23706=3A_Refac?= =?utf-8?q?tor_SONNX?= Message-ID: <158995480488.19379.10445085220705740168.asfpy@gitbox.apache.org> Date: Wed, 20 May 2020 06:06:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: joddiy commented on issue #706: URL: https://github.com/apache/singa/issues/706#issuecomment-631257280 1. can you extract the values for the shape from the tensor and pass them to init Reshape? Yes, I'm going to do this. 2. running_mean and running_var are not params (not updated via sgd). They are state variables. Got it, but I canot see the set_states yet at Layer class. 3. out_channel is required. Rename it to nb_kernels. Got it, I think I can parse the out_channels from the ONNX's weight. 4. With SONNXModel, I think we do not need metaclass anymore. You just need to consider the aux_output Yes, this part has been done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org