From dev-return-5377-archive-asf-public=cust-asf.ponee.io@singa.apache.org Tue May 19 15:21:36 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0B863180638 for ; Tue, 19 May 2020 17:21:35 +0200 (CEST) Received: (qmail 27930 invoked by uid 500); 19 May 2020 15:21:35 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 27920 invoked by uid 99); 19 May 2020 15:21:35 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2020 15:21:35 +0000 From: =?utf-8?q?GitBox?= To: dev@singa.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bsinga=5D_chrishkchris_commented_on_a_change_in_pul?= =?utf-8?q?l_request_=23694=3A_SINGA-510_Add_Time_Profiling_for_Single_GPU?= Message-ID: <158990169534.19379.2582604396889215094.asfpy@gitbox.apache.org> Date: Tue, 19 May 2020 15:21:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: chrishkchris commented on a change in pull request #694: URL: https://github.com/apache/singa/pull/694#discussion_r427388628 ########## File path: include/singa/core/scheduler.h ########## @@ -68,6 +76,11 @@ class Node { OpFunc op_; EdgeVec in_edges_; EdgeVec out_edges_; + + string op_name_; + float time_elapsed_ = 0; + int iteration_ = 0; Review comment: moved the variable to the graph, provide a step() function in graph to increment step counter ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org