From dev-return-5293-archive-asf-public=cust-asf.ponee.io@singa.apache.org Sat May 16 08:48:19 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 62F72180626 for ; Sat, 16 May 2020 10:48:19 +0200 (CEST) Received: (qmail 90372 invoked by uid 500); 16 May 2020 08:48:18 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 90362 invoked by uid 99); 16 May 2020 08:48:18 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 May 2020 08:48:18 +0000 From: =?utf-8?q?GitBox?= To: dev@singa.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bsinga=5D_nudles_edited_a_comment_on_issue_=23691?= =?utf-8?q?=3A_Add_save_and_load_method_for_Module_class?= Message-ID: <158961889863.19379.1450663572266935174.asfpy@gitbox.apache.org> Date: Sat, 16 May 2020 08:48:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: nudles edited a comment on issue #691: URL: https://github.com/apache/singa/issues/691#issuecomment-629610649 1. I think you can still store numpy arrays in singabackend. Copy data from numpy array into the param tensors directly later. 2. The new APIs are more consistent. But users then do not call `load_states` explicitly. They do call `save_states()` explicitly. Not symmetric.. @dcslin any comments? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org