From dev-return-5239-archive-asf-public=cust-asf.ponee.io@singa.apache.org Thu May 14 10:37:46 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B4148180621 for ; Thu, 14 May 2020 12:37:45 +0200 (CEST) Received: (qmail 83199 invoked by uid 500); 14 May 2020 10:37:45 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 83188 invoked by uid 99); 14 May 2020 10:37:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 May 2020 10:37:45 +0000 From: =?utf-8?q?GitBox?= To: dev@singa.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bsinga=5D_dcslin_edited_a_comment_on_issue_=23696?= =?utf-8?q?=3A_Refactor_autograd_module?= Message-ID: <158945266493.19379.18340924625350346172.asfpy@gitbox.apache.org> Date: Thu, 14 May 2020 10:37:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: dcslin edited a comment on issue #696: URL: https://github.com/apache/singa/issues/696#issuecomment-628547912 To me this api is more clear. For example, the `model.compile([x])` make more sense as it require `x` as arg, compared to `model([x])` (first call for init purpose). Also introducing `train_one_batch()` gives flexibility on loss function and optim function. While `train_one_batch()` is only an interface, and let user to define, and there is no decorator for this method. It sounds like there is no enforcement for user to use this method. Maybe we can make it clear in documentation that this is singa-way to build the model to enforece this `train_one_batch()` method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org