singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] nudles commented on a change in pull request #694: SINGA-510 Add Time Profiling for Single GPU
Date Wed, 20 May 2020 09:24:50 GMT

nudles commented on a change in pull request #694:
URL: https://github.com/apache/singa/pull/694#discussion_r427867486



##########
File path: include/singa/core/device.h
##########
@@ -51,6 +51,17 @@ using std::vector;
 
 namespace singa {
 
+/// Method used by time profiling
+/// ProfilingMode == 0 (default) -> Chrono
+/// ProfilingMode == 1 -> Event (e.g. cudaEvent)
+enum ProfilingMode { useChrono, useEvent };

Review comment:
       I think nvidia suggests to use chrono for cpu and use cudaevent for gpu operations
because chorno may not measure the time correctly due to asynchronous execution; 
   then we do not need users to select the mode.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message