singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] nudles commented on a change in pull request #694: SINGA-510 Add Time Profiling for Single GPU
Date Wed, 20 May 2020 08:59:03 GMT

nudles commented on a change in pull request #694:
URL: https://github.com/apache/singa/pull/694#discussion_r427851193



##########
File path: include/singa/core/device.h
##########
@@ -51,6 +51,17 @@ using std::vector;
 
 namespace singa {
 
+/// Method used by time profiling
+/// ProfilingMode == 0 (default) -> Chrono
+/// ProfilingMode == 1 -> Event (e.g. cudaEvent)
+enum ProfilingMode { useChrono, useEvent };
+
+/// Verbosity of the time profiling function:
+/// Verbosity == 0 (default) -> no logging
+/// Verbosity == 1 -> display forward and backward propagation time
+/// Verbosity == 2 -> display each operation time (OP_ID, op name, time)
+enum Verbosity { disableLog, forwardBackwardTime, eachOperation };

Review comment:
       I think verbosity is typically set as a number...
   We can refer to other project's code on how to set verbosity, giving it a name or just
using int.
   logging has INFO, WARN, ERROR, which are self-explainable. 

##########
File path: include/singa/core/device.h
##########
@@ -51,6 +51,17 @@ using std::vector;
 
 namespace singa {
 
+/// Method used by time profiling
+/// ProfilingMode == 0 (default) -> Chrono
+/// ProfilingMode == 1 -> Event (e.g. cudaEvent)
+enum ProfilingMode { useChrono, useEvent };

Review comment:
       I think chorno is only applicable for measuring cpu time and cudaevent is for measuring
gpu time.
   e.g., we cannot use cudaEvent if we are running on cpu.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message