From dev-return-4823-archive-asf-public=cust-asf.ponee.io@singa.apache.org Sat Apr 4 14:12:16 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D939818065C for ; Sat, 4 Apr 2020 16:12:15 +0200 (CEST) Received: (qmail 77353 invoked by uid 500); 4 Apr 2020 14:12:15 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 77343 invoked by uid 99); 4 Apr 2020 14:12:15 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Apr 2020 14:12:15 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [singa-doc] nudles commented on a change in pull request #9: Documentation about computational graph Message-ID: <158600953510.28124.5639121192047109085.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sat, 04 Apr 2020 14:12:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nudles commented on a change in pull request #9: Documentation about computational graph URL: https://github.com/apache/singa-doc/pull/9#discussion_r403474334 ########## File path: docs-site/docs/autograd.md ########## @@ -68,6 +68,13 @@ For those operations that require parameters, we package them into a new class, `Layer` manages (stores) the parameters and calls the corresponding `Operation`s to implement the transformation. +### Module Review comment: Module vs Model? Does pytorch use Module? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services