From dev-return-4753-archive-asf-public=cust-asf.ponee.io@singa.apache.org Thu Apr 2 05:54:54 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5E55418067F for ; Thu, 2 Apr 2020 07:54:54 +0200 (CEST) Received: (qmail 60363 invoked by uid 500); 2 Apr 2020 05:54:53 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 60268 invoked by uid 99); 2 Apr 2020 05:54:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Apr 2020 05:54:53 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [singa] nudles commented on a change in pull request #645: add function comments for autograd Message-ID: <158580689339.11927.2764645605098117879.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 02 Apr 2020 05:54:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nudles commented on a change in pull request #645: add function comments for autograd URL: https://github.com/apache/singa/pull/645#discussion_r402064790 ########## File path: python/singa/autograd.py ########## @@ -631,16 +712,39 @@ def backward(self, dy): def add_bias(x, b, axis=0): + """ + Add Bias to each row / column of the Tensor, depending on the axis arg. + Args: + x: matrix. + b (CTensor): bias to be added. Review comment: pls try to make the docstring consistent. e.g., some variables have (CTensor) whereas some do not have. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services