singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] chrishkchris commented on a change in pull request #651: Add new example APIs
Date Mon, 06 Apr 2020 03:05:07 GMT
chrishkchris commented on a change in pull request #651: Add new example APIs
URL: https://github.com/apache/singa/pull/651#discussion_r403807239
 
 

 ##########
 File path: src/api/dist_communicator.i
 ##########
 @@ -44,7 +44,7 @@ public:
   int totalMPIRanksInGlobal;
   int MPIRankInLocal;
   Communicator(int limit);
-  Communicator(int gpu_num, int gpu_per_node, const NcclIdHolder &holder, int limit);
+  Communicator(int gpu_num, int num_gpus, const NcclIdHolder &holder, int limit);
 
 Review comment:
   how about I change all the code including python and C++ to <rank, local_rank, world_size>
?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message