From dev-return-4603-archive-asf-public=cust-asf.ponee.io@singa.apache.org Sun Mar 22 14:23:31 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C2E7D180645 for ; Sun, 22 Mar 2020 15:23:30 +0100 (CET) Received: (qmail 94090 invoked by uid 500); 22 Mar 2020 14:23:30 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 94080 invoked by uid 99); 22 Mar 2020 14:23:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Mar 2020 14:23:30 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [singa-doc] FeynmanDNA commented on a change in pull request #5: Update some documentation files Message-ID: <158488701001.16038.4624014722333347832.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 22 Mar 2020 14:23:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit FeynmanDNA commented on a change in pull request #5: Update some documentation files URL: https://github.com/apache/singa-doc/pull/5#discussion_r396099285 ########## File path: docs-site/docs/contribute-code.md ########## @@ -18,120 +18,70 @@ A simple way to enforce the Google coding styles is to use the linting and forma Once the extensions are installed, edit the `settings.json` file. -```json +```json { - "[cpp]": { - "editor.defaultFormatter": "xaver.clang-format" - }, - "cpplint.cpplintPath": "path/to/cpplint", - - "editor.formatOnSave": true, - "python.formatting.provider": "yapf", - "python.linting.enabled": true, - "python.linting.lintOnSave": true, - "clang-format.language.cpp.style": "google", - "python.formatting.yapfArgs" : ["--style" , "{based_on_style: google}" ] + "[cpp]": { + "editor.defaultFormatter": "xaver.clang-format" + }, + "cpplint.cpplintPath": "path/to/cpplint", + + "editor.formatOnSave": true, + "python.formatting.provider": "yapf", + "python.linting.enabled": true, + "python.linting.lintOnSave": true, + "clang-format.language.cpp.style": "google", + "python.formatting.yapfArgs": ["--style", "{based_on_style: google}"] } ``` Depending on your platform, the user settings file is located here: + 1. Windows %APPDATA%\Code\User\settings.json -2. macOS $HOME/Library/Application Support/Code/User/settings.json -3. Linux $HOME/.config/Code/User/settings.json +2. macOS \$HOME/Library/Application Support/Code/User/settings.json Review comment: probably this is due to the linting and formatting, maybe you can try wrap these paths in ticks 2. macOS `$HOME/Library/Application Support/Code/User/settings.json` 3. Linux `$HOME/.config/Code/User/settings.json` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services