From dev-return-4601-archive-asf-public=cust-asf.ponee.io@singa.apache.org Sun Mar 22 13:50:29 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2BAF018066D for ; Sun, 22 Mar 2020 14:50:29 +0100 (CET) Received: (qmail 65908 invoked by uid 500); 22 Mar 2020 13:50:28 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 65887 invoked by uid 99); 22 Mar 2020 13:50:28 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Mar 2020 13:50:28 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [singa-doc] nudles commented on a change in pull request #5: Update some documentation files Message-ID: <158488502838.1373.348987088964713658.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 22 Mar 2020 13:50:28 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nudles commented on a change in pull request #5: Update some documentation files URL: https://github.com/apache/singa-doc/pull/5#discussion_r396095906 ########## File path: docs-site/docs/contribute-code.md ########## @@ -18,120 +18,70 @@ A simple way to enforce the Google coding styles is to use the linting and forma Once the extensions are installed, edit the `settings.json` file. -```json +```json { - "[cpp]": { - "editor.defaultFormatter": "xaver.clang-format" - }, - "cpplint.cpplintPath": "path/to/cpplint", - - "editor.formatOnSave": true, - "python.formatting.provider": "yapf", - "python.linting.enabled": true, - "python.linting.lintOnSave": true, - "clang-format.language.cpp.style": "google", - "python.formatting.yapfArgs" : ["--style" , "{based_on_style: google}" ] + "[cpp]": { Review comment: how many spaces should be added for indent in Docusaurus? 3 or 4? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services