singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] moazreyad opened a new pull request #620: SINGA-508 Add licence check with Apache Rat in Travis
Date Tue, 03 Mar 2020 09:13:58 GMT
moazreyad opened a new pull request #620: SINGA-508 Add licence check with Apache Rat in Travis
URL: https://github.com/apache/singa/pull/620
 
 
   Currently it fails because:
   
   1. It dose not use [rat-excludes](https://github.com/apache/singa/blob/master/rat-excludes).
Also this file is not complete. There are many files and directories that must be excluded
because they are mentioned in [LICENSE](https://github.com/apache/singa/blob/master/LICENSE).
We may use the [excludes option](https://creadur.apache.org/rat/apache-rat-plugin/rat-mojo.html#excludes)
to fix this.
   
   2. It executes after `git submodule update ` which downloads Rafiki code. The code has
no licence header. We can add the licence to Rafiki, add Rafiki to the excluded directories
from check, or run the check before downloading Rafiki code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message