singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa-doc] FeynmanDNA commented on a change in pull request #5: Update some documentation files
Date Sun, 22 Mar 2020 14:25:08 GMT
FeynmanDNA commented on a change in pull request #5: Update some documentation files
URL: https://github.com/apache/singa-doc/pull/5#discussion_r396099455
 
 

 ##########
 File path: docs-site/docs/contribute-code.md
 ##########
 @@ -18,120 +18,70 @@ A simple way to enforce the Google coding styles is to use the linting
and forma
 
 Once the extensions are installed, edit the `settings.json` file.
 
-```json 
+```json
 {
-   "[cpp]": {
-      "editor.defaultFormatter": "xaver.clang-format"
-   },
-   "cpplint.cpplintPath": "path/to/cpplint",
-
-   "editor.formatOnSave": true,
-   "python.formatting.provider": "yapf",
-   "python.linting.enabled": true,
-   "python.linting.lintOnSave": true,
-   "clang-format.language.cpp.style": "google",
-   "python.formatting.yapfArgs" : ["--style" , "{based_on_style: google}" ]
+  "[cpp]": {
 
 Review comment:
   usually, JS files are indenting with 2 spaces
   https://github.com/apache/singa-doc/blob/0f8de13fe9decc307fbb8205397edc7650e26017/docs-site/.prettierrc#L7

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message