singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] dcslin commented on a change in pull request #624: SINGA-487 Include NCCL and MPICH in conda build
Date Wed, 18 Mar 2020 05:49:51 GMT
dcslin commented on a change in pull request #624: SINGA-487 Include NCCL and MPICH in conda
build
URL: https://github.com/apache/singa/pull/624#discussion_r394118802
 
 

 ##########
 File path: tool/conda/dist/meta.yaml
 ##########
 @@ -0,0 +1,38 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+{% set version = "2.1.0.dev" %}
 
 Review comment:
   We can remove `{% set version = "2.1.0.dev" %}`.
   
   Assume that git latest tag is always available and reliable, then we could replace all
`{{ version }}` with `{{ environ.get('GIT_DESCRIBE_TAG') }}`.
   
   One side effect is in travis build, we need to `git fetch --unshallow` to get all the tags(including
latest) from remote to build environment before build starts. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message