From dev-return-4323-archive-asf-public=cust-asf.ponee.io@singa.apache.org Sun Feb 23 07:22:48 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 55F56180674 for ; Sun, 23 Feb 2020 08:22:48 +0100 (CET) Received: (qmail 57259 invoked by uid 500); 23 Feb 2020 07:22:47 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 57249 invoked by uid 99); 23 Feb 2020 07:22:47 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Feb 2020 07:22:47 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [singa] dcslin edited a comment on issue #599: Enabled linting check in CI Message-ID: <158244256762.19402.10434886877272808300.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 23 Feb 2020 07:22:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit dcslin edited a comment on issue #599: Enabled linting check in CI URL: https://github.com/apache/singa/pull/599#issuecomment-590035249 > > > Do the warnings fail the travis testing? > > > > > > In current setting, travis is simply checking the returned value of our script `linting.sh`. > > The main problem here is there are a lot of constraint with standard linting configuration. I doubt that any large scale project could fullfil all the linting constraint. So the second problem is to find a balance between linting on everything and linting on nothing. > > Thus I set both linting to show only critical one for now > > Then Travis will always pass as long as the linting script can run without errors no matter whether the linting is passed or not? `linting.sh` return the returned value from `pylint`/`cpplint` Travis checks `linting.sh` returned value which is effectively the returned value of `pylint`/`cpplint` So if `pylint`/`cpplint` return non 0, Travis fails if `pylint`/`cpplint` return 0, Travis passes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services