From dev-return-4316-archive-asf-public=cust-asf.ponee.io@singa.apache.org Sat Feb 22 03:38:00 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 201FF180657 for ; Sat, 22 Feb 2020 04:38:00 +0100 (CET) Received: (qmail 1769 invoked by uid 500); 22 Feb 2020 03:37:59 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 1759 invoked by uid 99); 22 Feb 2020 03:37:59 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Feb 2020 03:37:59 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [singa] chrishkchris commented on issue #599: Enabled linting check in CI Message-ID: <158234267919.20465.8499811069289306628.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sat, 22 Feb 2020 03:37:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit chrishkchris commented on issue #599: Enabled linting check in CI URL: https://github.com/apache/singa/pull/599#issuecomment-589913702 > Do the warnings fail the travis testing? > In current setting, travis is simply checking the returned value of our script linting.sh. > The main problem here is there are a lot of constraint with standard linting configuration. I doubt that any large scale project could fullfil all the linting constraint. > > @dcslin I suggest you can paste an example of the linting result here, so everyone can understand how many errors are in the linting result that are too hard to resolve > > Hi @chrishkchris , I'd love to, but since the purpose of integrating linting into CI, thus we could just leverage CI and see the output in the travis log by clicking travis build log. Yes, I saw you were setting both linting to show only critical one, and I think that would work well so I removed my comment ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services