From dev-return-4251-archive-asf-public=cust-asf.ponee.io@singa.apache.org Wed Feb 19 10:58:38 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 33595180658 for ; Wed, 19 Feb 2020 11:58:38 +0100 (CET) Received: (qmail 67025 invoked by uid 500); 19 Feb 2020 10:58:37 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 67014 invoked by uid 99); 19 Feb 2020 10:58:37 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Feb 2020 10:58:37 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [singa] chrishkchris commented on issue #603: format on latest dev Message-ID: <158210991738.24561.7945071968049484588.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 19 Feb 2020 10:58:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit chrishkchris commented on issue #603: format on latest dev URL: https://github.com/apache/singa/pull/603#issuecomment-588162124 > Hi After sync-ing all the versions between different OS > # yapf --version > yapf 0.29.0 > # clang-format --version > clang-format version 9.0.0 (https://github.com/mgevaert/clang-format-wheel d3a647c305759f37f30257352e621579f53d0073) > > the result is almost constistent except one small code snippet, yapf on ubuntu gives left result, while osx and windows give right result. (same yapf version and config) > 4739c6e > Kindly let me know any comment and it is helpful to test at your side. thanks @dcslin Thanks a lot! You mean even the same python code formatting yapf version gives different result in ubuntu and osx/window? So what OS this PR is based on? I think this should be the last point we should make the same when we update the instruction in singa-doc ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services