From dev-return-4243-archive-asf-public=cust-asf.ponee.io@singa.apache.org Wed Feb 19 08:57:52 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E71F7180658 for ; Wed, 19 Feb 2020 09:57:51 +0100 (CET) Received: (qmail 2316 invoked by uid 500); 19 Feb 2020 08:57:51 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 2302 invoked by uid 99); 19 Feb 2020 08:57:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Feb 2020 08:57:51 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [singa] chrishkchris commented on issue #603: format on latest dev Message-ID: <158210267125.27993.5658175205211442070.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 19 Feb 2020 08:57:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit chrishkchris commented on issue #603: format on latest dev URL: https://github.com/apache/singa/pull/603#issuecomment-588108173 > agree! > Does this PR fix this version issue? @nudles The version of clang-formatter depends on the version of LLVM we installed in our OS, So all the developer should have the same version of LLVM installed on their computer to make the version of clang-formatter the same. This PR only use the clang-formatter 9.0 to format the current singa code. @dcslin please correct me if I am wrong ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services