From dev-return-4241-archive-asf-public=cust-asf.ponee.io@singa.apache.org Wed Feb 19 07:10:42 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 22B3C180658 for ; Wed, 19 Feb 2020 08:10:42 +0100 (CET) Received: (qmail 13564 invoked by uid 500); 19 Feb 2020 07:10:41 -0000 Mailing-List: contact dev-help@singa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@singa.apache.org Delivered-To: mailing list dev@singa.apache.org Received: (qmail 13552 invoked by uid 99); 19 Feb 2020 07:10:41 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Feb 2020 07:10:41 +0000 From: GitBox To: dev@singa.apache.org Subject: [GitHub] [singa] chrishkchris commented on issue #603: format on latest dev Message-ID: <158209624134.11053.848481132844396311.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 19 Feb 2020 07:10:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit chrishkchris commented on issue #603: format on latest dev URL: https://github.com/apache/singa/pull/603#issuecomment-588069221 > Hi After sync-ing all the versions between different OS > # yapf --version > yapf 0.29.0 > # clang-format --version > clang-format version 9.0.0 (https://github.com/mgevaert/clang-format-wheel d3a647c305759f37f30257352e621579f53d0073) > > the result is almost constistent except one small code snippet, yapf on ubuntu gives left result, while osx and windows give right result. (same yapf version and config) > 4739c6e > Kindly let me know any comment and it is helpful to test at your side. thanks @joddiy I think your formatter should be upgraded to this version, so all the versions we use will be the same ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services