singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] dcslin edited a comment on issue #599: Enabled linting check in CI
Date Sun, 23 Feb 2020 07:22:47 GMT
dcslin edited a comment on issue #599: Enabled linting check in CI
URL: https://github.com/apache/singa/pull/599#issuecomment-590035249
 
 
   > > > Do the warnings fail the travis testing?
   > > 
   > > 
   > > In current setting, travis is simply checking the returned value of our script
`linting.sh`.
   > > The main problem here is there are a lot of constraint with standard linting
configuration. I doubt that any large scale project could fullfil all the linting constraint.
So the second problem is to find a balance between linting on everything and linting on nothing.
   > > Thus I set both linting to show only critical one for now
   > 
   > Then Travis will always pass as long as the linting script can run without errors
no matter whether the linting is passed or not?
   
   `linting.sh` return the returned value from `pylint`/`cpplint`
   Travis checks `linting.sh` returned value which is effectively the returned value of  `pylint`/`cpplint`
   So if `pylint`/`cpplint` return non 0, Travis fails
   if `pylint`/`cpplint` return 0, Travis passes
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message