singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] chrishkchris edited a comment on issue #599: Enabled linting check in CI
Date Sat, 22 Feb 2020 04:06:54 GMT
chrishkchris edited a comment on issue #599: Enabled linting check in CI
URL: https://github.com/apache/singa/pull/599#issuecomment-589915136
 
 
   @dcslin 
   I saw one interesting error:
   https://travis-ci.org/apache/singa/jobs/653724760#L2049
   The error is caused because there is no long data type in python 3.X, long data type was
used in python 2.X.
   https://stackoverflow.com/questions/2104884/how-does-python-manage-int-and-long
   However, this error will not cause any runtime error in python 3.X because the whole line
is 
   `if isinstance(repeats, int) or isinstance(repeats, long):`
   
   I suggest there could be two ways to solve:
   1. Mute the error type (undefined-variable) in pylint
   2. Change the python code (e.g. change the line to if isinstance(repeats, int): ) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message