singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] chrishkchris commented on issue #599: Enabled linting check in CI
Date Sat, 22 Feb 2020 03:37:59 GMT
chrishkchris commented on issue #599: Enabled linting check in CI
URL: https://github.com/apache/singa/pull/599#issuecomment-589913702
 
 
   > Do the warnings fail the travis testing?
   > In current setting, travis is simply checking the returned value of our script linting.sh.
   > The main problem here is there are a lot of constraint with standard linting configuration.
I doubt that any large scale project could fullfil all the linting constraint.
   > 
   > @dcslin I suggest you can paste an example of the linting result here, so everyone
can understand how many errors are in the linting result that are too hard to resolve
   > 
   > Hi @chrishkchris , I'd love to, but since the purpose of integrating linting into
CI, thus we could just leverage CI and see the output in the travis log by clicking travis
build log.
   
   Yes, I saw you were setting both linting to show only critical one, and I think that would
work well so I removed my comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message