singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] dcslin commented on issue #603: format on latest dev
Date Thu, 20 Feb 2020 02:57:42 GMT
dcslin commented on issue #603: format on latest dev
URL: https://github.com/apache/singa/pull/603#issuecomment-588584344
 
 
   > > Hi After sync-ing all the versions between different OS
   > > # yapf --version
   > > yapf 0.29.0
   > > # clang-format --version
   > > clang-format version 9.0.0 (https://github.com/mgevaert/clang-format-wheel d3a647c305759f37f30257352e621579f53d0073)
   > > the result is almost constistent except one small code snippet, yapf on ubuntu
gives left result, while osx and windows give right result. (same yapf version and config)
   > > [4739c6e](https://github.com/apache/singa/commit/4739c6e7ee639fbcded04d09c621d49bce0862f9)
   > > Kindly let me know any comment and it is helpful to test at your side. thanks
   > 
   > @dcslin Thanks a lot!
   > You mean even the same python code formatting yapf version gives different result
in ubuntu and osx/window? So which OS this PR is based on? I think this should be the last
point we should make the same when we update the instruction in singa-doc. Personally I prefer
window/osx as I do not have the ubuntu os to be installed with vscode.
   
   Among hunderds of files in Singa, there are only a few lines of mis-match, which is showed
in https://github.com/apache/singa/commit/4739c6e7ee639fbcded04d09c621d49bce0862f9
   
   Currently the code format result is on **OSX/Wins**. I agree with you on the preference
on OSX/wins.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message