singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [singa] chrishkchris commented on issue #603: format on latest dev
Date Wed, 19 Feb 2020 09:09:07 GMT
chrishkchris commented on issue #603: format on latest dev
URL: https://github.com/apache/singa/pull/603#issuecomment-588112823
 
 
   > agree!
   > Does this PR fix this version issue?
   > @nudles
   > The version of clang-formatter depends on the version of LLVM we installed in our
OS, So all the developer should have the same version of LLVM installed on their computer
to make the version of clang-formatter the same. This PR only use the clang-formatter 9.0
to format the current singa code.
   > @dcslin please correct me if I am wrong
   > 
   > download link of LLVM 9.0 to provide clang-format version 9.0.0
   > http://releases.llvm.org/download.html#9.0.1
   
   so to fix the formatting issue I suggest we may update the instruction in sing-doc how
to reproduce the same formatting

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message