singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Moaz Reyad (Jira)" <>
Subject [jira] [Commented] (SINGA-485) Code Coverage Analysis
Date Thu, 05 Sep 2019 12:58:00 GMT


Moaz Reyad commented on SINGA-485:

??In fact, the current travis configuration will run the unit tests for python via conda test??

Yes, the current Travis configuration runs Python unit tests (instead of C++ unit tests) in
the C++ CI tasks. So there are two problems:
 # It does not run the C++ unit tests, which is supposed to happen because only [C++ language|]
is given in the [build matrix|].
 # It runs Python unit tests on the C++ build machines that are not prepared to support Python.
It installs Python on the C++ build machines instead of using Python CI build by adding language:python
to the build matrix. It also seems to test both Python 2 and Python 3 in the same item.

Some refactoring is required here in my opinion.

??Does the code coverage analysis give us a report on how to improve the code??

It will give a report on which parts of the code is not executed by the test. Here are some
examples from Apache project that use [codecov|] and [coverall|].

> Code Coverage Analysis
> ----------------------
>                 Key: SINGA-485
>                 URL:
>             Project: Singa
>          Issue Type: Improvement
>            Reporter: Moaz Reyad
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
> SINGA development and testing can be improved by using a [code coverage|]
> Some Apache projects use [codecov|], while others
use [coverall|].
> This issue is open to choose a code coverage tool and add it to SINGA build and test

This message was sent by Atlassian Jira

View raw message