singa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-singa] nudles commented on a change in pull request #533: fixed operation add assertion for convolution
Date Sat, 14 Sep 2019 03:42:36 GMT
nudles commented on a change in pull request #533: fixed operation add assertion for convolution
URL: https://github.com/apache/incubator-singa/pull/533#discussion_r324410807
 
 

 ##########
 File path: src/core/tensor/tensor_math_cpp.h
 ##########
 @@ -868,6 +868,25 @@ void RowMax<float, lang::Cpp>(const Tensor& in, Tensor *out,
Context *ctx) {
   }
 }
 
+template <>
+void SoftMax<float, lang::Cpp>(const Tensor& in, Tensor* out, Context *ctx) {
 
 Review comment:
   do we need to move SoftMax into tensor_math_cpp.h?
   If not, please delete the changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message